Update onProposedFederationChange in order to register SVP spend tx in the Bridge #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
marcos-iov
force-pushed
the
feat/powpeg_validation_protocol-phase4
branch
from
5244d90 to
931420f
Compare
apancorb
force-pushed
the
feat/allow_svp_spend_tx
branch
from
111ea90 to
57bb818
Compare
… can register the svp spend tx
… logic to register svp spend tx
apancorb
force-pushed
the
feat/allow_svp_spend_tx
branch
from
487f63b to
e76a824
Compare
apancorb
commented
Dec 11, 2024
Comment on lines
+59
to
+61
| // add proposed federation to active btc to rsk client so | ||
| // it can register svp spend tx in the bridge | ||
| bitcoinWrapper.addFederationListener(newProposedFederation, btcToRskClientActive); |
There was a problem hiding this comment.
This is the main and only change of the PR, the rest are small refactors
There was a problem hiding this comment.
Isn't this done already in btcReleaseClient.start?
apancorb
changed the title
apancorb
changed the title
|
marcos-iov
approved these changes
Dec 12, 2024
marcos-iov
merged commit 815a509
into
feat/powpeg_validation_protocol-phase4
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this approach we add the
proposedFederationto the list of watched federations that theBitcoinWrapperlistens to. Since the svp spend tx will be considered as a peg-out from the perspective of theBitcoinWrapperfederation listener it will allow it to be registered with no problem.Motivation and Context
https://github.com/rsksmart/RSKIPs/blob/master/IPs/RSKIP419.md
How Has This Been Tested?
This was tested in Regtest, and complete the SVP protocol:
2024-12-11-11:49:16.930 INFO [c.r.p.BridgeSupport] [registerSvpSpendTx] Going to commit the proposed federation.Types of changes
Checklist: