Ignore non-standard outputs when searching for the witness commitment hash #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
|
Add witness related constants that were removed
jeremy-then
reviewed
Jan 13, 2025
| public static final byte[] WITNESS_COMMITMENT_HEADER = Hex.decode("aa21a9ed"); | ||
| public static final Sha256Hash WITNESS_RESERVED_VALUE = Sha256Hash.ZERO_HASH; | ||
| public static final int WITNESS_COMMITMENT_LENGTH = WITNESS_COMMITMENT_HEADER.length + Sha256Hash.LENGTH; | ||
| public static final int MINIMUM_WITNESS_COMMITMENT_SIZE = WITNESS_COMMITMENT_LENGTH + 2; // 1 extra by for OP_RETURN and another one for data length |
There was a problem hiding this comment.
Suggested change
| public static final int MINIMUM_WITNESS_COMMITMENT_SIZE = WITNESS_COMMITMENT_LENGTH + 2; // 1 extra by for OP_RETURN and another one for data length | |
| public static final int MINIMUM_WITNESS_COMMITMENT_SIZE = WITNESS_COMMITMENT_LENGTH + 2; // 1 extra byte for OP_RETURN and another one for data length |
?
jeremy-then
approved these changes
Jan 13, 2025
nathanieliov
force-pushed
the
coinbase-parsing
branch
from
00ae431 to
3d07157
Compare
- Updated BridgeEventLoggerImpl constructor call - Fix failing tests - Update places using BitcoinUtils.findWitnessCommitment to use new method signature.
nathanieliov
force-pushed
the
coinbase-parsing
branch
from
3d07157 to
3ef94c3
Compare
|
Replaced by #378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore non-standard outputs when searching for the witness commitment hash
## Motivation and Context
Coinbase transactions may sometimes contain non-standard outputs that cause the Bridge to fail parsing them. When iterating through the outputs of a coinbase transaction in search for the witness commitment hash, non-standard outputs should be ignored and continue searching through the remaining outputs.
How Has This Been Tested?
Unit tests
Types of changes
Checklist:
rskj:coinbase-parsing-integration-rebased