Feature/powpeg validation protocol integration #374

julia-zack · 2025-01-10T18:59:29Z

Changes needed to implement SVP, described in RSKIP419

Description

Implementation of the Powpeg Spendability Validation Protocol, as described in RSKIP419

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

rskj:feature/powpeg_validation_protocol-integration
rit:disable-rskip419

github-actions · 2025-01-10T18:59:43Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

src/main/java/co/rsk/federate/bitcoin/BitcoinWrapperImpl.java

+            TransactionListener listener = watched.getListener();
+            Wallet watchedFederationWallet = new BridgeBtcWallet(btcContextThin, Collections.singletonList(watchedFederation));
+
+            if (PegUtilsLegacy.isValidPegInTx(btcTx, watchedFederation, watchedFederationWallet, bridgeConstants, federatorSupport.getConfigForBestBlock())) {


src/main/java/co/rsk/federate/bitcoin/BitcoinWrapperImpl.java

+                listener.onTransaction(tx);
+            }
+
+            if (PegUtilsLegacy.isPegOutTx(btcTx, Collections.singletonList(watchedFederation), federatorSupport.getConfigForBestBlock())) {


src/main/java/co/rsk/federate/btcreleaseclient/BtcReleaseClient.java

+         * </p>
+         *
+         * @param currentBlockNumber the current block number in the blockchain
+         * @param svpTxHash the Keccak256 hash of the svp spend transaction waiting to be signed


src/test/java/co/rsk/federate/FederationProviderFromFederatorSupportTest.java

+        Federation expectedFederation = createP2shErpFederation(
+            getFederationMembersFromPks(1, 1000, 2000, 3000, 4000, 5000));
+        Address expectedFederationAddress = expectedFederation.getAddress();
+        Integer federationSize = 5;


…ventLoggerImpl in tests

…support

…void using Optional as parameters

…tcher

…en starting

…e federation when starting

…g federation

… avoid confusion

…the federation

…implementation without Optional

…stop client methods

…the new federation should throw exception

…rt of new federationa and fix the rest of exisiting tests to accomdate new condition

…ethod

…orSupport class

… not exist

…e to build federation after validating the federation size

…nChange

…tionChange

…ses in FederationWatcherTest

…her class

… implementing an anoymous class per test

…ation to follow chrono order

…cherTest class

…vation check

… can register the svp spend tx

… logic to register svp spend tx

sonarqubecloud · 2025-01-17T15:40:15Z

Quality Gate passed

Issues
28 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.1% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

marcos-iov force-pushed the feature/powpeg_validation_protocol-integration branch from 00b0319 to dbd0236 Compare January 10, 2025 20:36

github-advanced-security bot found potential problems Jan 10, 2025

View reviewed changes

marcos-iov force-pushed the feature/powpeg_validation_protocol-integration branch from dbd0236 to 1fa8546 Compare January 15, 2025 14:24

marcos-iov marked this pull request as ready for review January 15, 2025 14:24

marcos-iov requested a review from a team as a code owner January 15, 2025 14:24

marcos-iov force-pushed the feature/powpeg_validation_protocol-integration branch from 1fa8546 to 7aaee31 Compare January 15, 2025 17:19

apancorb added 23 commits January 17, 2025 12:35

refactor(fed): federation watcher tests

4880878

feat(federate): change access modifier for federation watcher listerner

2ad52bd

fix(btcreleaseclient): remove signature cache dependency from BridgeE…

2f64531

…ventLoggerImpl in tests

feat(federate): implement getProposedFederationAddress in federation …

44d4e58

…support

feat(bitcoin): add bitcoin test util methods

0d1fc76

refactor(watcher): refactor federation watcher to its own package

0141296

refactor(watcher): simplify FederationWatcherListener interface and a…

feb04fc

…void using Optional as parameters

refactor(watcher): organize and remove some comments for FederationWa…

970bd25

…tcher

feat(btcreleaseclient): federator should be part of the federation wh…

959d509

…en starting

feat(federate): throw an exception if federator is not a member of th…

9b8c820

…e federation when starting

feat(watcher): change stop and starting logic when active and retirin…

f42ddb4

…g federation

refactor(watcher): rename interface variables to be more explicit and…

fd35e17

… avoid confusion

fix(federate): solve unit tests since was using a member not part of …

ec8b42b

…the federation

refactor(watcher): change updateActiveFederation to use the original …

225a1ff

…implementation without Optional

refactor(watcher): small code structure change and better logging

9aef1c1

feat(watcher): make the active federation be required to be non-null

a5adc16

refactor(btcreleaseclient): make better log statements for start and …

7243352

…stop client methods

fix(btcreleaseclient): if the member running the node is not part of …

7c1e1c2

…the new federation should throw exception

feat(btcreleaseclient): add unit test for federation member is not pa…

0daf69c

…rt of new federationa and fix the rest of exisiting tests to accomdate new condition

feat(watcher): add unit tests for FederationWatcherListenerImpl

8b39470

feat(config): add description for isPegoutEnabled parameter

21114f8

refactor(federate): remove unused method getLiveFederations

ca64896

refactor(federate): remove unused unit tests for getLiveFederations m…

1724576

…ethod

apancorb and others added 28 commits January 17, 2025 12:35

feat(federate): wrap logic for building the retiring fed in try-catch

de828fb

refactor(federate): enhance javadoc for FederationProviderFromFederat…

41a0d1a

…orSupport class

feat(federate): add unit test when getting addr for retiring fed does…

a02d3ed

… not exist

feat(federate): allow exception to propagate in the listener if unabl…

f41358b

…e to build federation after validating the federation size

feat(watcher): add onProposedFederation method to interface

aa42066

feat(watcher): intial implementation of onProposedFederationChange

e466c1b

feat(watcher): enhance with try-catch and logging onProposedFederatio…

24a2638

…nChange

feat(watcher): use javadoc annotation for comment in onProposedFedera…

d031b75

…tionChange

feat(watcher): add unit tests for onProposedFederationChange

226033e

feat(watcher): implement onProposedFederationChange for anoymous clas…

5f4dea3

…ses in FederationWatcherTest

feat(watcher): add logic for change in proposed fed in FederationWatc…

52e7481

…her class

refactor(watcher): use mock of federation watcher listener instead of…

73b14bd

… implementing an anoymous class per test

feat(watcher): accomdate existing unit tests for proposed fed logic

4d27db9

feat(watcher): call updateProposedFederation before updateActiveFeder…

6f4bfb1

…ation to follow chrono order

feat(watcher): add unit test for proposed federation in FederationWat…

232bbf7

…cherTest class

refactor(wathcer): log statement for onProposedFederationChange

85dc6fc

refactor(watcher): test naming and log statements

3a292fa

fix(federate): add RSKIP419 check for proposed federation methods

3f5f5b9

Adapt to time unit bridge method change

72a5e05

Add tests pre rskip 419

35649ec

fix(btcreleaseclient): place call to get svp spend tx wfs behind acti…

b19f6ee

…vation check

fix(watcher): add correct log prefix

42745d4

feat(bitcoin): add logic to detect when processing a svp spend tx

2c7efb8

refactor(federate): add proper spacing between code segments

cfbce55

refactor(federate): move code segments in BtcToRskClient

ad7dbb1

feat(bitcoin): remove svp spend tx handling in BitcoinWrapperImpl

13d4130

feat(watcher): add BitcoinWrapper to onProposedFederationChange so it…

e243551

… can register the svp spend tx

feat(watcher): update unit tests to accomdate BitcoinWrapper listener…

7231fa9

… logic to register svp spend tx

marcos-iov force-pushed the feature/powpeg_validation_protocol-integration branch from 7aaee31 to 7231fa9 Compare January 17, 2025 15:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/powpeg validation protocol integration #374

Feature/powpeg validation protocol integration #374

julia-zack commented Jan 10, 2025 •

edited by marcos-iov

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

sonarqubecloud bot commented Jan 17, 2025

Feature/powpeg validation protocol integration #374

Are you sure you want to change the base?

Feature/powpeg validation protocol integration #374

Conversation

julia-zack commented Jan 10, 2025 • edited by marcos-iov Loading

Description

Types of changes

github-actions bot commented Jan 10, 2025 • edited Loading

Dependency Review

OpenSSF Scorecard

Scanned Manifest Files

sonarqubecloud bot commented Jan 17, 2025

Quality Gate passed

julia-zack commented Jan 10, 2025 •

edited by marcos-iov

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading