Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup readme #15

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Update setup readme #15

merged 8 commits into from
Oct 31, 2023

Conversation

ed-iov
Copy link
Contributor

@ed-iov ed-iov commented Oct 18, 2023

Added some detailed information in the readme to do the first local setup, added additional regtest.js sample for hsm1 use only and a logback file as example to do the logs configuration.

@ed-iov ed-iov requested a review from a team as a code owner October 18, 2023 18:56
@lucasvuotto
Copy link
Contributor

pipeline: run

1 similar comment
@lucasvuotto
Copy link
Contributor

pipeline: run

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ed-iov ed-iov requested a review from nathanieliov October 26, 2023 13:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@nathanieliov nathanieliov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcos-iov marcos-iov merged commit c9c372a into main Oct 31, 2023
4 checks passed
@marcos-iov marcos-iov deleted the update-setup-readme branch October 31, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants