Add pegout with weis rounded down to satoshis test #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-then
force-pushed
the
add-pegout-request-from-contract-test
branch
from
11c5790 to
913b560
Compare
jeremy-then
force-pushed
the
add-pegout-with-weis-rounded-down-to-satoshis-test
branch
from
b5984e2 to
4f507e4
Compare
nathanieliov
approved these changes
Oct 31, 2024
marcos-iov
reviewed
Nov 4, 2024
lib/constants.js
Outdated
Comment on lines
127
to
129
| const FEE_PER_KB_CHANGE_PK = '6a4b49312b91e203ddfb9bc2d900ebbd46fbede46a7462e770bedcb11ad405e9'; | ||
| const FEE_PER_KB_CHANGE_ADDR = '53f8f6dabd612b6137215ddd7758bb5cdd638922'; | ||
|
|
There was a problem hiding this comment.
Wasn't this previously added?
lib/tests/2wp.js
Outdated
Comment on lines
860
to
863
| const senderRecipientInfo = await createSenderRecipientInfo(rskTxHelper, btcTxHelper); | ||
| const peginValueInSatoshis = btcToSatoshis(0.5); | ||
| const btcPeginTxHash = await sendPegin(rskTxHelper, btcTxHelper, senderRecipientInfo.btcSenderAddressInfo, satoshisToBtc(peginValueInSatoshis)); | ||
| await ensurePeginIsRegistered(rskTxHelper, btcPeginTxHash); |
There was a problem hiding this comment.
Isn't there a new util function for this?
lib/tests/2wp.js
Outdated
Comment on lines
867
to
865
| const pegoutValueInWeisBN = new BN('41234567891234560'); // 0.04123456789123456 in RBTC | ||
| const expectedPegoutValueInSatoshis = 4123456; // 0.04123456 in BTC |
There was a problem hiding this comment.
Can't we use the unit converter library to somehow make this clearer?
There was a problem hiding this comment.
It turns out, we cant. The unit converter rounds differently than the Bridge. The unit converter would yield 4123457, and the Bridge 4123456. So, I had to hardcode it.
There was a problem hiding this comment.
Should we update the unit converter library then?
|
jeremy-then
merged commit 1308096
into
add-pegout-request-from-contract-test
2 of 3 checks passed
jeremy-then
deleted the
add-pegout-with-weis-rounded-down-to-satoshis-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pegout with weis rounded down to satoshis test