Redeem script tests refactor #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-then
reviewed
Nov 14, 2023
jeremy-then
reviewed
Nov 24, 2023
jeremy-then
reviewed
Nov 24, 2023
Removes peglib from utils.js
nathanieliov
reviewed
Dec 6, 2023
|
pipeline:run |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 new tests that is repeating the test for 01_05_57-post_hop_active_powpeg_redeem_script.js into 2 new files
03_02_01-last_fork_active_powpeg_redeem_script.js - validates that in the last fork activation the redeem script is correct.
05_02_01-last_fork_active_powpeg_redeem_script.js - validates that in the last fork activation and a federation change the redeem script is correct for the new federation.