Adds missing migration test #225
Conversation
|
| @@ -25,28 +25,36 @@ async function clearLogFiles(directory) { | |||
| } | |||
| } | |||
|
|
|||
| function deleteBitcoinDataDirectory() { | |||
| function clearBitcoinDataDirectory() { | |||
There was a problem hiding this comment.
Refactored this utility to delete all files and directory inside the bitcoin data directory, but not the bitcoin data directory itself.
| @@ -120,6 +133,17 @@ const execute = (description, newFederationConfig) => { | |||
| await btcTxHelper.importAddress(initialFederationAddress, 'federations'); | |||
| await btcTxHelper.importAddress(expectedNewFederationAddress, 'federations'); | |||
|
|
|||
| minimumPeginValueInSatoshis = Number(await bridge.methods.getMinimumLockTxValue().call()); | |||
|
|
|||
| if(makeDonationPegins) { | |||
There was a problem hiding this comment.
Ideal for the first federation change when there is no utxo in the Bridge yet.
There was a problem hiding this comment.
Rather than adding this logic here, I would maybe put it in tests/00_00_05-change-federation.js before calling this file. Or could be a file prior, a test of it's own that only sends some UTXOs to the Bridge.
It's probably better organized that way, and we don't add logic here that only applies for one case
There was a missing test in the new federation change tests: a migration utxo test. This pr adds it.