Initial version from github actions workflow #45
Conversation
fmacleal
force-pushed
the
feature/add-integration-tests-with-github-actions
branch
2 times, most recently
from
2320280 to
10c4875
Compare
fmacleal
force-pushed
the
feature/add-integration-tests-with-github-actions
branch
23 times, most recently
from
aa0e256 to
30678ff
Compare
|
pipeline:run |
marcos-iov
force-pushed
the
feature/add-integration-tests-with-github-actions
branch
from
015fa88 to
59502c2
Compare
|
pipeline:run |
3 similar comments
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
| fi | ||
| POWPEG_VERSION=$1 | ||
| shift | ||
| echo "POWPEG_VERSION received as parameter: $1" |
There was a problem hiding this comment.
| echo "POWPEG_VERSION received as parameter: $1" | |
| echo "POWPEG_VERSION received as parameter: $POWPEG_VERSION" |
The shift changes the value of $1. In particular, given that the script aborts if it doesn't have exacly one parameter, this is accessing an unset variable. Depending on how it's run, that can be an error or a warning.
container-action/Dockerfile
Outdated
| RUN export JAVA_HOME="$JAVA_HOME" \ | ||
| && export PATH="$JAVA_HOME:$PATH" |
There was a problem hiding this comment.
This is a no-op and adds an extra layer to the container. The reach of those export are for the whole RUN instruction, not for all the ones after. My understanding is that the previous ENV JAVA_HOME=... should be enough.
|
pipeline:run |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
container-action/Dockerfile
Outdated
| && apt-get install -y --no-install-recommends \ | ||
| wget gnupg2 curl git ca-certificates mocha \ |
Check notice
Code scanning / SonarCloud
Arguments in long RUN instructions should be sorted
|
pipeline:run |
3 similar comments
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
container-action/README.md
Outdated
|
|
||
| ## Inputs | ||
| By default, all the inputs are pointed to the `master/main` branch of the repositories. But, ideally, we will adapt | ||
| the action to receive the branches received to be the one in a branch or tag that we want to test. |
There was a problem hiding this comment.
This last part is a bit confusing
container-action/README.md
Outdated
| ### `rit-branch` | ||
|
|
||
| **Optional** The rootstock-integration-tests branch to checkout. This one it's optional, because it will be | ||
| very unlikely that we need to use a different branch for the rootstock-integration-test. It's offered the possibility |
There was a problem hiding this comment.
I wouldn't say it's very unlikely. Sometimes a new feature requires a change in the RIT so we need to use a specific RIT branch to run the tests along with the feature changes in rskj/powpeg.
Also, when there is a change to the RIT code and a PR against master we also want the tests to run with the RIT branch that has the changes included
| <!-- <filter class="ch.qos.rit-local-configs.classic.filter.ThresholdFilter"> | ||
| <level>DEBUG</level> | ||
| </filter> --> |
There was a problem hiding this comment.
Should we keep this and other commented out parts?
There was a problem hiding this comment.
Nopes, I will remove it.
lib/rsk-utils-legacy.js
Outdated
| const waitForBlockAttemptTimeMillis = process.env.WAIT_FOR_BLOCK_ATTEMPT_TIME_MILLIS || 200; | ||
| const waitForBlockMaxAttempts = process.env. WAIT_FOR_BLOCK_MAX_ATTEMPTS || 160; |
There was a problem hiding this comment.
The tests are failing when executed against this branch. I think it might be related to this, or maybe it's the default values set in configure_rit_locally.sh file.
Could you set them back to the original values please?
.gitignore
Outdated
| @@ -7,3 +7,4 @@ config/*.js | |||
| logs | |||
| .env | |||
| .DS_Store | |||
| .idea/ | |||
There was a problem hiding this comment.
We should a blank line at the end of this and other files that github is reporting
|
|
pipeline:run |
2 similar comments
|
pipeline:run |
|
pipeline:run |
marcos-iov
deleted the
feature/add-integration-tests-with-github-actions
branch
In order to be able to easily have more external contributors, we need to migrate some private pipelines running on jenkins to Github Actions.
This PR starts this migration, executing the steps necessary to run the integration tests between powpeg-node and rskj inside Github actions.