Added firmware static analysis to CI #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
italo-sampaio
commented
Dec 14, 2023
•
italo-sampaio
commented
- Merged old static analysis scripts into a single script
- Added static analysis to the CI on pushes to master
- Generated report is available for download on job summary
italo-sampaio
force-pushed
the
enhancement/add-static-analysis
branch
from
c9ea90d to
363064b
Compare
Unified the signer and ui static analysis scripts into a single script is located under the more specific folder ledger/static-analysis. Also modified the directory of the generated reports to be under the ledger/static-analysis folder.
Added a new action to CI that runs static analysis on the firmware code. A failure in static analysis won't prevent the checks from passing, this is only informational at the moment. The generated reports are uploaded as a github artifact and can be analyzed offline.
italo-sampaio
force-pushed
the
enhancement/add-static-analysis
branch
from
363064b to
5764341
Compare
|
An example run can be seen here. |
italo-sampaio
changed the title
amendelzon
previously approved these changes
Jan 9, 2024
Good question. The clang used for building the firmware is actually located at I'll update the script to also use the |
This makes it clear that we are using the same compiler for building the firmware and for static analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.