Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate V2 x509_pem type element validation #240

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

amendelzon
Copy link
Collaborator

  • Implemented HSMCertificateV2ElementX509's is_valid method
  • Added root of trust element validation in SGX attestation verification
  • Added and updated unit tests

- Implemented HSMCertificateV2ElementX509's is_valid method
- Added root of trust element validation in SGX attestation verification
- Added and updated unit tests
italo-sampaio
italo-sampaio previously approved these changes Jan 6, 2025
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

middleware/admin/certificate_v2.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit 92445fd into feature/sgx-attestation Jan 7, 2025
5 checks passed
@amendelzon amendelzon deleted the enhancement/sgx-x509-validator branch January 7, 2025 17:07
This was referenced Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants