- Change log level to warn level since it may more sense for unhandle…

…d exceptions.

- Use all activations instead of lovell

rskj-core/src/main/java/co/rsk/peg/bitcoin/BitcoinUtils.java

@@ -16,7 +16,7 @@
 public class BitcoinUtils {
     protected static final byte[]  WITNESS_COMMITMENT_HEADER = Hex.decode("aa21a9ed");
     protected static final int WITNESS_COMMITMENT_LENGTH = WITNESS_COMMITMENT_HEADER.length + Sha256Hash.LENGTH;
-    private static final int MINIMUM_WITNESS_COMMITMENT_SIZE = WITNESS_COMMITMENT_LENGTH + 2; // 1 extra by for OP_RETURN and another one for data length
+    private static final int MINIMUM_WITNESS_COMMITMENT_SIZE = WITNESS_COMMITMENT_LENGTH + 2; // 1 extra byte for OP_RETURN and another one for data length
     private static final Logger logger = LoggerFactory.getLogger(BitcoinUtils.class);
     private static final int FIRST_INPUT_INDEX = 0;
 
@@ -125,7 +125,7 @@ public static Optional<Sha256Hash> findWitnessCommitment(BtcTransaction tx, Acti
                     return Optional.of(witnessCommitment);
                 }
             } catch (ScriptException e) {
-                logger.debug(
+                logger.warn(
                     "[findWitnessCommitment] Failed to extract witness commitment from output {}. {}",
                     output,
                     e.getMessage()

rskj-core/src/test/java/co/rsk/peg/bitcoin/BitcoinUtilsTest.java

@@ -32,7 +32,7 @@ class BitcoinUtilsTest {
     private static final int FIRST_INPUT_INDEX = 0;
 
     private static final ActivationConfig.ForBlock arrowHeadActivations = ActivationConfigsForTest.arrowhead600().forBlock(0);
-    private static final ActivationConfig.ForBlock lovellActivations = ActivationConfigsForTest.lovell700().forBlock(0);
+    private static final ActivationConfig.ForBlock allActivations = ActivationConfigsForTest.all().forBlock(0);
 
     private Address destinationAddress;
 
@@ -553,7 +553,7 @@ void findWitnessCommitment_whenTxHasNoOutputs_shouldThrowException(ActivationCon
         private static Stream<Arguments> activationsProvider() {
             return Stream.of(
                 Arguments.of(arrowHeadActivations),
-                Arguments.of(lovellActivations)
+                Arguments.of(allActivations)
             );
         }
 
@@ -663,7 +663,7 @@ void findWitnessCommitment_withRealTransaction_shouldReturnExpectedValue(Activat
 
         @ParameterizedTest
         @MethodSource("activationsProvider")
-        void findWitnessCommitment_withDataLargenThanExpected_shouldReturnEmpty(ActivationConfig.ForBlock activations) {
+        void findWitnessCommitment_withDataLargerThanExpected_shouldReturnEmpty(ActivationConfig.ForBlock activations) {
             // Arrange
             BtcTransaction btcTx = BitcoinTestUtils.createCoinbaseTransaction(btcMainnetParams);
 
@@ -716,7 +716,7 @@ void findWitnessCommitment_whenMalFormedTxAfterRSKIP460_shouldIgnoreMalformedOut
             BtcTransaction malFormedCoinbaseTx, Sha256Hash expectedWitnessCommitment) {
             // Act
             Optional<Sha256Hash> witnessCommitment = BitcoinUtils.findWitnessCommitment(
-                malFormedCoinbaseTx, lovellActivations);
+                malFormedCoinbaseTx, allActivations);
 
             // Assert
             assertTrue(witnessCommitment.isPresent());