Mark invalid pegin as processed #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
marcos-iov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
b877d0a to
da9c490
Compare
marcos-iov
force-pushed
the
feature/powpeg_validation_protocol-integration
branch
from
09ff25b to
2545809
Compare
nathanieliov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
da9c490 to
34a2c25
Compare
marcos-iov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
34a2c25 to
326de39
Compare
Base automatically changed from
feature/powpeg_validation_protocol-integration
to
master
January 24, 2025 18:45
marcos-iov
approved these changes
Jan 24, 2025
…jected pegin should be marked as processed - Update BridgeSupportRegisterBtcTransactionTest to assert rejected pegin are marked as processed since RSKIP459 - Add tests asserting rejected pegin are marked as processed once RSKIP459 is active
- Make logic handling rejected pegin functional using the Optional API - Fix formatting
- Enhance switch for processing each PeginProcessAction
marcos-iov
force-pushed
the
invalid-pegin-as-processed-integration-rebased
branch
from
326de39 to
7b48c64
Compare
|
josedahlquist
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark rejected pegins as processed once RSKIP459 is active.
Motivation and Context
Peg-in transactions rejected by the Bridge should be marked as processed to ensure that the
rejected_peginevent is emitted only once per transaction.How Has This Been Tested?
Unit tests
Types of changes
Checklist: