Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always evaluate renderDT()'s ... in the parent.frame() #1130

Merged
merged 3 commits into from
Mar 14, 2024
+3 −1
Merged

Always evaluate renderDT()'s ... in the parent.frame() #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc51ab4
Close #1129. Always evaluate renderDT()'s ... in the parent.frame()
cpsievert Mar 14, 2024
8ee9fb3
Update NEWS
cpsievert Mar 14, 2024
1af6a0f
Update NEWS.md [ci skip]
yihui Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

- Added `outputArgs` parameter to `renderDataTable`, to allow width and height to be set when using interactive R Markdown documents.

- Fixed a bug in `renderDT()`'s evaluation of `...` arguments when `quoted = TRUE` (#1130).

# CHANGES IN DT VERSION 0.32

- Fixed a bug that caused the column used for grouping with the RowGroup extension to change when relocated by the ColReorder extension (thanks, @isthisthat, @mikmart, #1109).
Expand Down
2 changes: 1 addition & 1 deletion R/shiny.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ renderDataTable = function(
outputInfoEnv[["session"]] = NULL

exprFunc = shiny::exprToFunction(expr, env, quoted = TRUE)
argFunc = shiny::exprToFunction(list(..., server = server), env, quoted = FALSE)
argFunc = shiny::exprToFunction(list(..., server = server), parent.frame(), quoted = FALSE)
widgetFunc = function() {
opts = options(DT.datatable.shiny = TRUE); on.exit(options(opts), add = TRUE)
instance = exprFunc()
Expand Down