don't bundle() unprepped steps (#56)

* don't `bundle()` unprepped steps * Remove extra `prep()` * Use ubuntu latest --------- Co-authored-by: Julia Silge <[email protected]>
rstudio · Sep 6, 2023 · 6347111 · 6347111
1 parent 1498c88
commit 6347111
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/R-CMD-check-hard.yaml b/.github/workflows/R-CMD-check-hard.yaml
@@ -24,7 +24,7 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - {os: ubuntu-18.04,   r: 'release'}
+          - {os: ubuntu-latest,   r: 'release'}
 
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # bundle (development version)
 
+* Fixed bundling of recipes steps situated inside of workflows.
+
 # bundle 0.1.0
 
 * Initial CRAN release of package
diff --git a/R/bundle_workflows.R b/R/bundle_workflows.R
@@ -52,14 +52,12 @@ bundle.workflow <- function(x, ...) {
   rlang::check_dots_empty()
 
   res <- swap_element(x, "fit", "fit")
-  res <- swap_element(res, "pre", "actions", "recipe", "recipe")
   res <- swap_element(res, "pre", "mold", "blueprint", "recipe")
 
   bundle_constr(
     object = res,
     situate = situate_constr(function(object) {
       res <- bundle::swap_element(object, "fit", "fit")
-      res <- bundle::swap_element(res, "pre", "actions", "recipe", "recipe")
       res <- bundle::swap_element(res, "pre", "mold", "blueprint", "recipe")
 
       structure(res, class = !!class(x))

diff --git a/tests/testthat/test_bundle_workflows.R b/tests/testthat/test_bundle_workflows.R
@@ -148,8 +148,7 @@ test_that("bundling + unbundling tidymodels workflows (lm + step_umap)", {
 
     rec <-
       recipe(mpg ~ ., data = mtcars) %>%
-      step_umap(all_predictors(), outcome = vars(mpg), num_comp = 2) %>%
-      prep()
+      step_umap(all_predictors(), outcome = vars(mpg), num_comp = 2)
 
     mod <-
       workflow() %>%