Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid error with emtpy string (see Dockerfile) #672

Closed
wants to merge 3 commits into from
Closed

avoid error with emtpy string (see Dockerfile) #672

wants to merge 3 commits into from

Conversation

adRn-s
Copy link

@adRn-s adRn-s commented Dec 5, 2023

The env variable RSW_TESTUSER_UID was set to 10000 in previous versions, now it's an empty string by default, which makes this if statement to fail, I just saw it on my docker logs.

Swapping the order of the if statements makes it so that we only search for RSW_TESTUSER_UID's username via getent in the case that we had the first switch (RSW_TESTUSER) set.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@melissa-barca melissa-barca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this fix! Sorry for the delayed review. Could you bring the branch up to date?

Copy link
Author

@adRn-s adRn-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just updated my branch with the latest commits from rstudio:dev

@maxplanck-ie maxplanck-ie closed this by deleting the head repository Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants