Bump Connect to version 2024.01.0 #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Package Manager's Python version
Upgrade WGCW to 2023.12.0
Lytol
requested review from
a team,
colearendt,
ianpittwood and
bschwedler
as code owners
Lytol
requested review from
shepherdjerred and
nunyunuymi
and removed request for
a team
shepherdjerred
approved these changes
Jan 25, 2024
aronatkins
requested changes
Jan 25, 2024
| @@ -30,7 +30,7 @@ jobs: | |||
| - {product: "workbench", type: "preview", os: "ubuntu2204", r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.9.17", py-alternate: "3.8.17"} | |||
| - {product: "connect", type: "daily", os: "ubuntu2204", r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.9.17", py-alternate: "3.8.17"} | |||
| - {product: "connect-content-init", type: "daily", os: "ubuntu2204", r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.9.17", py-alternate: "3.8.17"} | |||
| - {product: "package-manager", type: "daily", os: "ubuntu2204", r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.9.17", py-alternate: "3.8.17"} | |||
| - {product: "package-manager", type: "daily", os: "ubuntu2204", r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.12.1", py-alternate: "3.11.7"} | |||
There was a problem hiding this comment.
I don't understand why the Connect changes are adjusting the package-manager data.
There was a problem hiding this comment.
I think it was a bad rebase/merge. If you look at the commits tab it contains the commits that modify these files.
| @@ -30,6 +30,7 @@ jobs: | |||
| - {os: 'ubuntu2204', r-primary: "4.2.0", r-alternate: "3.6.2", py-primary: "3.9.5", py-alternate: "3.8.10"} | |||
| - {os: 'ubuntu2204', r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.9.14", py-alternate: "3.8.15"} | |||
| - {os: 'ubuntu2204', r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.9.17", py-alternate: "3.8.17"} | |||
| - {os: 'ubuntu2204', r-primary: "4.2.3", r-alternate: "4.1.3", py-primary: "3.12.1", py-alternate: "3.11.7"} | |||
There was a problem hiding this comment.
related: The Connect changes should not be modifying this information.
| ARG PYTHON_VERSION=3.9.17 | ||
| ARG PYTHON_VERSION_ALT=3.8.17 | ||
| ARG PYTHON_VERSION=3.12.1 | ||
| ARG PYTHON_VERSION_ALT=3.11.7 |
There was a problem hiding this comment.
Why are the Package Manager versions changing in this PR?
|
As everyone all noticed, this PR is wonky so I'll be closing and re-opening. I'm investigating root causes on our release script to see why this is happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created automatically by the Posit Connect release scripts.