Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbench configuration and certificate bug patches #813

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Workbench configuration and certificate bug patches #813

merged 7 commits into from
Jul 19, 2024

Conversation

ianpittwood
Copy link
Collaborator

@ianpittwood ianpittwood commented Jul 10, 2024 •
edited
Loading

  • Since Workbench's debian package currently attempts to start Workbench as a service during builds, a race condition can be created where Workbench begins to initialize and cannot finish before the builder kills the process during stage cleanup. This can cause files to be created with incorrect permissions. This change adds a 30sec delay after Workbench's installation for it to finish initializing. It also adds an immediate successor step to remove any certificate files that may have been generated.
  • launcher-env files are fixed to point to /opt/python/default for the Python path.
  • Adds launcher.pem and launcher.pub files to the .dockerignore and .gitignore files to ensure they are not accidentally added to image builds.

@ianpittwood ianpittwood marked this pull request as ready for review July 15, 2024 19:47
@ianpittwood ianpittwood changed the title Explicitly ignore launcher .pem files for Docker Workbench configuration and certificate bug patches Jul 19, 2024
cm421
cm421 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@cm421 cm421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianpittwood ianpittwood merged commit 7ac3377 into dev Jul 19, 2024
38 checks passed
@ianpittwood ianpittwood deleted the fix-wgcw-waml-builds branch July 19, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cm421 cm421 cm421 approved these changes

@kfeinauer kfeinauer kfeinauer approved these changes

@melissa-barca melissa-barca Awaiting requested review from melissa-barca melissa-barca is a code owner

@colearendt colearendt Awaiting requested review from colearendt

@bschwedler bschwedler Awaiting requested review from bschwedler bschwedler is a code owner

@costrouc costrouc Awaiting requested review from costrouc costrouc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianpittwood @kfeinauer @cm421