Update datatables.js from 1.10.5 to 1.10.22 and deprecate renderDataTable()/dataTableOutput()
#3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Mar 15, 2024
cpsievert
changed the title
renderDataTable()/DTOutput()renderDataTable()/dataTableOutput()
cpsievert
commented
Mar 15, 2024
jcheng5
approved these changes
Mar 19, 2024
jcheng5
reviewed
Mar 19, 2024
cpsievert
commented
Mar 19, 2024
cpsievert
added a commit
to rstudio/shinycoreci
that referenced
this pull request
Mar 20, 2024
cpsievert
added a commit
to rstudio/shinycoreci
that referenced
this pull request
Mar 20, 2024
* Updates for rstudio/shiny#3998 * Just use legacy for both * Set the option in the app itself
cpsievert
added a commit
that referenced
this pull request
Mar 20, 2024
cpsievert
added a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3627
Closes #3986
Related rstudio/DT#1130, rstudio/DT#1128, and rstudio/DT#1132
This PR updates datatables.js from v1.10.5 to v1.10.22 to address the security issue discussed in #3627.
It also makes it so
renderDataTable()/dataTableOutput()throw a deprecation message to use their{DT}equivalents. Also, if a suitable (upcoming) version of{DT}is available, they automatically dispatch to their{DT}equivalents (renderDT/DTOutput()). In this case, the user will also see a message about settingoptions(shiny.legacy.datatable = TRUE)if they'd still like the old implementation.