Handle empty custom messages #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LoveToKnow/slackify-markdown-actionfails if text input is empty.So it's only called if the respective env var is set.
In the actual call to
action-slack-notifyi overwrite empty values of those custom env vars with the default messageSLACK_MESSAGEbecause otherwise the messages would be empty since the implementation ofenvOrinmain.goonly checks if the env var is set and not if the value is an empty string.It's not beautiful but it's a limitation of the fact that
GITHUB_ENVcannot be overwritten in composite workflows.