Adds Default options in wp_options table to allow manipulating options from WP CLI. #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SH4LIN
requested changes
Sep 24, 2024
| $options = get_site_option( 'rt_wp_nginx_helper_options', array() ); | ||
| $default_settings = $this->nginx_helper_default_settings(); | ||
|
|
||
| $removable_default_settings = array( |
There was a problem hiding this comment.
Why are we removing these settings from the list of settings to be stored in the options table?
There was a problem hiding this comment.
@SH4LIN These are redis configurations that if stored by default are populating the redis input fields, but on fresh install the nginx_cache purge method is selected which is causing inconsistencies in behaviour.
SH4LIN
reviewed
Sep 27, 2024
admin/class-nginx-helper-admin.php
Outdated
| unset( $default_settings[ $removable_key ] ); | ||
| } | ||
|
|
||
| $diffed_options = wp_parse_args( $default_settings, $options ); |
There was a problem hiding this comment.
According to the documentation and function signature, keep the default options as the second argument and the options ($args) as the first.
|
@Vedant-Gandhi Please check why test is failing before merging. |
|
@SH4LIN The action is throwing an error because it is utilising a deprecated version of the upload artifact API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to add support for purging AMP URL's.
Type
Reference Issue
Testing
The code has been tested locally and is working as expected.