Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pagination #1982

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

Utsav-Ladani
Copy link
Collaborator

@Utsav-Ladani Utsav-Ladani commented Jul 28, 2023

Fix Pagination

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update

Details

  • Earlier, there was only support for one shortcode.
  • This PR adds support for multiple shortcodes. The main focus is on the pagination issue.
  • Added Numerical and Load More pagination using backbone.js views and collections.
  • Other support also refactored, like search functionality on media gallery, sort options, etc.

Note

  • Few changes are made to rtMedia-Pro to fix the UI issue. So update both plugins' code to get the correct result.

Related PRs

@Utsav-Ladani Utsav-Ladani changed the base branch from develop to pre-release July 28, 2023 11:57
@Utsav-Ladani Utsav-Ladani marked this pull request as ready for review July 28, 2023 12:09
@Utsav-Ladani Utsav-Ladani requested a review from Pradeep1308 July 28, 2023 12:12
@Utsav-Ladani
Copy link
Collaborator Author

Utsav-Ladani commented Jul 28, 2023

I fixed the Pagination issue for the shortcode and media gallery. Please check and let me know if there is something wrong or broken.

Also, check out this PR in the rtMedia-Pro plugin, as it is necessary to fix the issue.

CC: @pavanpatil1, @kjnanda

@kjnanda
Copy link
Contributor

kjnanda commented Jul 31, 2023

@pavanpatil1 Handing over this issue to you!

CC @Utsav-Ladani

@pavanpatil1
Copy link
Contributor

Hi @Utsav-Ladani, verified the fix and it seems working fine. However, after clicking onload more the previous media are not visible. Please check.

loadmore.mp4

@Utsav-Ladani
Copy link
Collaborator Author

Hello @pavanpatil1, I fixed the issue. Now previous content is visible after loading new content in Load More pagination.

Base automatically changed from pre-release to develop November 16, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants