Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple uploader issue #1986

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Conversation

Utsav-Ladani
Copy link
Collaborator

@Utsav-Ladani Utsav-Ladani commented Aug 3, 2023

Fix multiple uploader issue

  • In the current version of the rtMedia Plugin, users cannot use multiple uploaders.
  • Previous code is designed so that only one uploader might work.
  • In this PR, added support for multiple uploaders using the backbone.js library.

Enhancement

  • Re-build all functionalities and divide the code into further parts to increase the readability.
  • Fix multiple uploaders issue.
  • Create multiple views, models, and collections to enhance the code reusability and robustness.
  • Add a few more highlighters to the file preview according to the current state of the uploading process to enhance the UI.
  • Add transition in the progress bar to make its movement smooth.
  • Add support for removing queued media while uploading ( media is in the queue, and the upload process is not started ).
  • Add appropriate messages and strings to better error logging.

Other fixes

  • Removed or unselected files will not be uploaded now in this version.
  • Reload the view after uploading using the rtGalleryObject view.

Note

  • There are different types of uploaders at different places, e.g., Activity comment, media page, shortcode, etc.
  • These changes only affect the shortcode and media page uploaders.
  • There will be a PR on the rtMedia Pro plugin to make related changes to support new changes in the rtMedia Core plugin.

Related Issues

Related PRs

@Utsav-Ladani Utsav-Ladani marked this pull request as ready for review August 3, 2023 11:48
@pavanpatil1
Copy link
Collaborator

Hi @Utsav-Ladani, verified the fix and the uploaded media is not visible. getting the console error. Refer below video.

consoleerror.webm

@Utsav-Ladani
Copy link
Collaborator Author

Hi @Utsav-Ladani, verified the fix and the uploaded media is not visible. getting the console error. Refer below video.

Can you send me the content of your post?

Base automatically changed from pre-release to develop November 16, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants