-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests : Add tests for CoreList
block.
#22
Conversation
Core List
block.CoreList
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #24 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
CoreListItem.parentClientId - This is is null in the response.
It's null when editorBlocks
arent flat
. To cover this, add a new test with a minimal $query
(of just the clientId + parent Client Ids on the list + listItem and compare.
Once that and the minimal comments are handled (and we take a stab at the b/c compatibility issue on WP 6.1) this should be good to merge.
To handle WP 6.1 failing, see the [slack instructions[(https://rtcamp.slack.com/archives/CK2CEH4F6/p1727126999500269?thread_ts=1726011552.525109&cid=CK2CEH4F6)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking wpengine#298
What:
This PR backfills tests for the
Core List
andCore List Item
block and their attributes.Tested attributes:
CoreListAttributes
CoreListItemAttributes
Untested fields:
CoreListAttributes.metadata
- @todoExposed issues:
CoreListAttributes.cssClassNames
- This is not working in the tests.These issues are noted in comments within the test file and should be addressed in future updates.