tests : backfill tests for Core Video Block
#29
Merged
+195
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justlevine
reviewed
Sep 25, 2024
justlevine
reviewed
Sep 25, 2024
justlevine
reviewed
Sep 25, 2024
justlevine
reviewed
Sep 25, 2024
justlevine
reviewed
Sep 25, 2024
justlevine
reviewed
Sep 25, 2024
justlevine
reviewed
Sep 25, 2024
|
@justlevine, I tried the rebase operation, not sure it was successfull or not (prolly not successful). |
|
cc. @justlevine , i think i just successfully rebased it on #25 ✅ most of the broken attributes seem to be have fixed ✅ |
Rebase looks good from the commit history will review the internals when I start my morning 🙇 |
|
nope I spoke too soon didnt see the base branch was wrong. Rebasing in progress... |
justlevine
force-pushed
the
core-video-test
branch
2 times, most recently
from
d08ae11
to
d01d3be
Compare
justlevine
changed the title
Core Video BlockCore Video Block
justlevine
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
@Ta5r - great work!
I squashed the history to make things easier to rebase and did a tiny bit of post-merge cleanup.
Go ahead and open this upstream 🚀
justlevine
force-pushed
the
core-video-test
branch
from
d01d3be
to
3a1157b
Compare
Co-authored-by: Ta5r <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking wpengine#304
What:
This PR backfills tests for the
Core Videoblock and its attributes.Important
This test is based on wpengine#293 which should be merged first.
Tested attributes :
Untested fields:
CoreVideoAttribute.metadata- @todoExposed issues:
NA