test : Add tests for Core Image Block
#30
Conversation
Ta5r
force-pushed
the
core-image-test
branch
from
1322f45
to
6da38bc
Compare
Ta5r
force-pushed
the
core-image-test
branch
from
60ba97e
to
11e0a17
Compare
tests/unit/CoreImageTest.php
Outdated
| final class CoreImageTest extends PluginTestCase { | ||
| public $instance; | ||
|
|
There was a problem hiding this comment.
| final class CoreImageTest extends PluginTestCase { | |
| public $instance; | |
| final class CoreImageTest extends PluginTestCase { | |
tests/unit/CoreImageTest.php
Outdated
| * Get the query for the CoreImage block. | ||
| * | ||
| * @param string $attributes The attributes to add to query. | ||
| */ | ||
| public function query( $attributes = '' ): string { |
There was a problem hiding this comment.
This new param isnt in use, lets remove it.
(If it was in use, there'd be a longer discussion whether the ingenuity here outweights a general desire to not obfuscate whats getting tested. Either way, smart approach 🙌)
There was a problem hiding this comment.
Oh yes, i was actually using it to return a valid query for every untested attribute ( ) check by just passing that label to it. but later i thought to instead use the query in each case to make it more readable
tests/unit/CoreImageTest.php
Outdated
| * - scale | ||
| * - lightbox | ||
| */ | ||
| public function test_retrieve_core_untested_attributes(): void { |
There was a problem hiding this comment.
Break this into two separate tests please.
At the top of each, gate it and $this->markTestSkipped() if its not the right WordPress version (like its done elsewhere), instead of wrapping the tests inside conditional logic.
|
May I proceed to merge this pull request ? @justlevine 😃 |
Tracking wpengine#306