New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be explicit on logout sending a null value #87

Open

nikoskalogridis wants to merge 1 commit into rtfeldman:master from nikoskalogridis:patch-1

nikoskalogridis commented Nov 19, 2019 •

edited

Loading

Instead of sending a Maybe value we send explicitly a Encode.null value in the logout function.

The main reason I am proposing this is that SimulatedEffect.Ports.send takes always a Decode.Value so its easier to test this.

It's also not preferred as said in the official elm docs

Sending Json.Decode.Value through ports is recommended, but not the only way


          Be explicit on logout sending a null value

982b9f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet