Establish elm review 446 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really nice thank you! I think we probably do not want to elm-review on our examples (we should keep them as simple as possible to emphasise the testing bits) which would also sidestep the subdir issue. |
This reverts commit 5552466.
Sounds good. I've removed the elm-review stuff for the examples. |
harrysarson
reviewed
Oct 19, 2020
| @@ -58,6 +59,7 @@ | |||
| "devDependencies": { | |||
| "elm": "0.19.1-3", | |||
| "elm-format": "0.8.3", | |||
| "elm-review": "^2.3.3", | |||
There was a problem hiding this comment.
Can we pin this dep:
Suggested change
| "elm-review": "^2.3.3", | |
| "elm-review": "2.3.3", |
harrysarson
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First try at #446. I'm not 100% happy with the config for the subdirs - e.g. example-package-no-tests has just a single source file, and I had to exclude this file from the single rule I've enabled so far, so elm-review for this is essentially a no-op.
Feedback / suggestions welcome :-)