Merge pull request #253 from rubensousa/1.4.0-alpha03

Make header visible by default
rubensousa · Aug 14, 2024 · f24ba3c · f24ba3c
2 parents b377caa + 99f008a
commit f24ba3c
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 4 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -2,6 +2,15 @@
 
 ## Version 1.4.0
 
+### 1.4.0-alpha03
+
+2024-08-14
+
+#### Bug fixes
+
+- Fix header not being initially shown sometimes with `DpadScrollableLayout` ([#253](https://github.com/rubensousa/DpadRecyclerView/pull/253))
+
+
 ### 1.4.0-alpha02
 
 2024-08-14

diff --git a/...Test/kotlin/com/rubensousa/dpadrecyclerview/test/tests/layout/DpadScrollableLayoutTest.kt b/...Test/kotlin/com/rubensousa/dpadrecyclerview/test/tests/layout/DpadScrollableLayoutTest.kt
@@ -405,8 +405,33 @@ class DpadScrollableLayoutTest {
             Rect(0, headerHeight / 2, screenWidth, headerHeight / 2 + headerHeight)
         )
         assertThat(recyclerViewBounds).isEqualTo(
-            Rect(0, headerHeight / 2 + headerHeight, screenWidth, screenHeight + headerHeight / 2 + headerHeight)
+            Rect(
+                0,
+                headerHeight / 2 + headerHeight,
+                screenWidth,
+                screenHeight + headerHeight / 2 + headerHeight
+            )
+        )
+    }
+
+    @Test
+    fun testHeaderIsVisibleByDefault() {
+        // given
+        val headerHeight = getHeaderHeight()
+        val screenWidth = getWidth()
+        var actualVisibility = false
+
+        // when
+        fragmentScenario.onFragment { fragment ->
+            actualVisibility = fragment.scrollableLayout?.isHeaderVisible ?: false
+        }
+
+        // then
+        val header1Bounds = getViewBounds(R.id.header1)
+        assertThat(header1Bounds).isEqualTo(
+            Rect(0, 0, screenWidth, headerHeight)
         )
+        assertThat(actualVisibility).isTrue()
     }
 
     private fun waitViewAtCoordinates(viewId: Int, top: Int, bottom: Int, timeout: Long = 4L) {

diff --git a/dpadrecyclerview/src/main/java/com/rubensousa/dpadrecyclerview/DpadScrollableLayout.kt b/dpadrecyclerview/src/main/java/com/rubensousa/dpadrecyclerview/DpadScrollableLayout.kt
@@ -52,7 +52,7 @@ class DpadScrollableLayout @JvmOverloads constructor(
     var headerHeight = 0
         private set
 
-    var isHeaderVisible = false
+    var isHeaderVisible = true
         private set
 
     private var currentOffset = 0

diff --git a/gradle.properties b/gradle.properties
@@ -22,4 +22,4 @@ kotlin.code.style=official
 # thereby reducing the size of the R class for that library
 android.nonTransitiveRClass=true
 android.enableR8.fullMode=true
-LIBRARY_VERSION=1.4.0-alpha02
+LIBRARY_VERSION=1.4.0-alpha03
diff --git a/mkdocs.yml b/mkdocs.yml
@@ -24,7 +24,7 @@ theme:
 
 extra:
   dpadrecyclerview:
-    version: '1.4.0-alpha02'
+    version: '1.4.0-alpha03'
   social:
     - icon: 'fontawesome/brands/github'
       link: 'https://github.com/rubensousa/DpadRecyclerView'