Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluginfy RuboCop Minitest #329

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 7, 2025

This PR adds support for RuboCop's Plugin feature:

rubocop/rubocop#13792

It replaces the ad-hoc Inject with RuboCop plugins introduced in RuboCop 1.72.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the pluginfy_with_lint_roller branch 5 times, most recently from d2c7efa to 3a373fb Compare February 11, 2025 14:50
@koic koic force-pushed the pluginfy_with_lint_roller branch from 3a373fb to ddb5d0c Compare February 14, 2025 23:31
This PR adds support for RuboCop's Plugin feature:
rubocop/rubocop#13792

It replaces the ad-hoc `Inject` with RuboCop plugins introduced in RuboCop 1.72.
@koic koic force-pushed the pluginfy_with_lint_roller branch from ddb5d0c to c0d3155 Compare February 15, 2025 16:03
@koic koic merged commit 26040f4 into rubocop:master Feb 15, 2025
15 checks passed
@koic koic deleted the pluginfy_with_lint_roller branch February 15, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant