Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_dependency of RuboCop to 1.72 for plugin support #330

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

koic
Copy link
Member

@koic koic commented Feb 15, 2025

RuboCop 1.72 or later is required for plugin support.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_require_rubocop_version_for_plugin branch from 06c809c to 48ceb59 Compare February 15, 2025 17:44
RuboCop 1.72 or later is required for plugin support.
@koic koic force-pushed the fix_require_rubocop_version_for_plugin branch from 48ceb59 to a306885 Compare February 15, 2025 17:46
@koic koic changed the title Update require_ruby_version to 1.72 for plugin Update add_dependency of RuboCop to 1.72 for plugin support Feb 15, 2025
@koic koic merged commit 9e6a6c7 into rubocop:master Feb 15, 2025
15 checks passed
@koic koic deleted the fix_require_rubocop_version_for_plugin branch February 15, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant