Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof Rails/Output for itblock #1460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Future-proof Rails/Output for itblock #1460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/rubocop/cop/rails/output.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ class Output < Base

MSG = "Do not write to stdout. Use Rails's logger if you want to log."
RESTRICT_ON_SEND = %i[ap p pp pretty_print print puts binwrite syswrite write write_nonblock].freeze
ALLOWED_TYPES = %i[send csend block numblock].freeze

def_node_matcher :output?, <<~PATTERN
(send nil? {:ap :p :pp :pretty_print :print :puts} ...)
Expand All @@ -40,7 +39,7 @@ class Output < Base
PATTERN

def on_send(node)
return if ALLOWED_TYPES.include?(node.parent&.type)
return if node.parent&.call_type? || node.block_node
return if !output?(node) && !io_output?(node)

range = offense_range(node)
Expand Down
Loading