Add RSpec/RedundantAround cop

.rubocop.yml

@@ -132,6 +132,8 @@ RSpec/NoExpectationExample:
   Enabled: true
 RSpec/PendingWithoutReason:
   Enabled: true
+RSpec/RedundantAround:
+  Enabled: true
 RSpec/SortMetadata:
   Enabled: true
 RSpec/SubjectDeclaration:

CHANGELOG.md

@@ -7,6 +7,7 @@
 - Fix a false positive for `RSpec/VariableName` when inside non-spec code. ([@ydah])
 - Fix a false positive for `RSpec/VariableDefinition` when inside non-spec code. ([@ydah])
 - Add new `RSpec/PendingBlockInsideExample` cop. ([@ydah])
+- Add `RSpec/RedundantAround` cop. ([@r7kamura])
 
 ## 2.18.1 (2023-01-19)
 

config/default.yml

@@ -712,6 +712,12 @@ RSpec/ReceiveNever:
   VersionAdded: '1.28'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveNever
 
+RSpec/RedundantAround:
+  Description: Remove redundant `around` hook.
+  Enabled: pending
+  VersionAdded: "<<next>>"
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantAround
+
 RSpec/RepeatedDescription:
   Description: Check for repeated description strings in example groups.
   Enabled: true

docs/modules/ROOT/pages/cops.adoc

@@ -72,6 +72,7 @@
 * xref:cops_rspec.adoc#rspecpredicatematcher[RSpec/PredicateMatcher]
 * xref:cops_rspec.adoc#rspecreceivecounts[RSpec/ReceiveCounts]
 * xref:cops_rspec.adoc#rspecreceivenever[RSpec/ReceiveNever]
+* xref:cops_rspec.adoc#rspecredundantaround[RSpec/RedundantAround]
 * xref:cops_rspec.adoc#rspecrepeateddescription[RSpec/RepeatedDescription]
 * xref:cops_rspec.adoc#rspecrepeatedexample[RSpec/RepeatedExample]
 * xref:cops_rspec.adoc#rspecrepeatedexamplegroupbody[RSpec/RepeatedExampleGroupBody]

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -4136,6 +4136,36 @@ expect(foo).not_to receive(:bar)
 
 * https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveNever
 
+== RSpec/RedundantAround
+
+|===
+| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
+
+| Pending
+| Yes
+| Yes
+| <<next>>
+| -
+|===
+
+Remove redundant `around` hook.
+
+=== Examples
+
+[source,ruby]
+----
+# bad
+around do |example|
+  example.run
+end
+
+# good
+----
+
+=== References
+
+* https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantAround
+
 == RSpec/RepeatedDescription
 
 |===

lib/rubocop/cop/rspec/redundant_around.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Remove redundant `around` hook.
+      #
+      # @example
+      #   # bad
+      #   around do |example|
+      #     example.run
+      #   end
+      #
+      #   # good
+      #
+      class RedundantAround < Base
+        extend AutoCorrector
+
+        MSG = 'Remove redundant `around` hook.'
+
+        RESTRICT_ON_SEND = %i[around].freeze
+
+        def on_block(node)
+          return unless match_redundant_around_hook_block?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+        alias on_numblock on_block
+
+        def on_send(node)
+          return unless match_redundant_around_hook_send?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        private
+
+        # @!method match_redundant_around_hook_block?(node)
+        def_node_matcher :match_redundant_around_hook_block?, <<~PATTERN
+          (block
+            (send _ :around ...)
+            (args _?)
+            (send _ :run)
+          )
+        PATTERN
+
+        # @!method match_redundant_around_hook_send?(node)
+        def_node_matcher :match_redundant_around_hook_send?, <<~PATTERN
+          (send
+            _
+            :around
+            ...
+            (block-pass
+              (sym :run)
+            )
+          )
+        PATTERN
+
+        def autocorrect(corrector, node)
+          corrector.remove(node)
+        end
+      end
+    end
+  end
+end

lib/rubocop/cop/rspec_cops.rb

@@ -96,6 +96,7 @@
 require_relative 'rspec/predicate_matcher'
 require_relative 'rspec/receive_counts'
 require_relative 'rspec/receive_never'
+require_relative 'rspec/redundant_around'
 require_relative 'rspec/repeated_description'
 require_relative 'rspec/repeated_example'
 require_relative 'rspec/repeated_example_group_body'

spec/rubocop/cop/rspec/redundant_around_spec.rb

@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::RedundantAround do
+  context 'with another node in `around`' do
+    it 'registers no offense' do
+      expect_no_offenses(<<~RUBY)
+        around do |example|
+          example.run
+
+          foo
+        end
+      RUBY
+    end
+  end
+
+  context 'with block-surrounded `run` in `around`' do
+    it 'registers no offense' do
+      expect_no_offenses(<<~RUBY)
+        around do |example|
+          foo { example.run }
+        end
+      RUBY
+    end
+  end
+
+  context 'with redundant `around`' do
+    it 'registers offense' do
+      expect_offense(<<~RUBY)
+        around do |example|
+        ^^^^^^^^^^^^^^^^^^^ Remove redundant `around` hook.
+          example.run
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+
+      RUBY
+    end
+  end
+
+  context 'with redundant block-pass `around`' do
+    it 'registers offense' do
+      expect_offense(<<~RUBY)
+        around(&:run)
+        ^^^^^^^^^^^^^ Remove redundant `around` hook.
+      RUBY
+
+      expect_correction(<<~RUBY)
+
+      RUBY
+    end
+  end
+
+  context 'with redundant numblock `around`' do
+    it 'registers offense' do
+      expect_offense(<<~RUBY)
+        around do
+        ^^^^^^^^^ Remove redundant `around` hook.
+          _1.run
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+
+      RUBY
+    end
+  end
+
+  context 'with redundant `config.around' do
+    it 'registers offense' do
+      expect_offense(<<~RUBY)
+        config.around do |example|
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Remove redundant `around` hook.
+          example.run
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+
+      RUBY
+    end
+  end
+
+  context 'with redundant `config.around(:each)' do
+    it 'registers offense' do
+      expect_offense(<<~RUBY)
+        config.around(:each) do |example|
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Remove redundant `around` hook.
+          example.run
+        end
+      RUBY
+
+      expect_correction(<<~RUBY)
+
+      RUBY
+    end
+  end
+end