Add configuration option AllowNested to RSpec/MultipleExpectations
#1810
Conversation
| expect_no_offenses(<<~RUBY) | ||
| describe Foo do | ||
| it 'uses expect with block twice' do | ||
| expect { my_code }.to raise_error(MyErrorType) do |error| |
There was a problem hiding this comment.
How would we count multiple nested expectations? As one or as multiple?
This really depends, right?
There was a problem hiding this comment.
What would happen if there will be two expectations inside the block?
There was a problem hiding this comment.
Oh, I understand. This is not an offense if there are multiple expectations in a block of the same block if it is completely nested, so instead, we need to count the number of expectations in the same block.
There was a problem hiding this comment.
Right. And this is getting interesting when the Max is above one.
So
ex is one
ex { ex } is one
ex { ex }
ex { ex }
is two
ex {
ex
ex
}
is two
etc
does this make sense?
There was a problem hiding this comment.
Hmm. Now that I look at it, I feel like adding this option makes it more confusing. Maybe AllowNested isn't such a good approach. I think I'll close this PR, but what do you think of @pirj ?
There was a problem hiding this comment.
I agree. And the ticket as well - i see some comments expressing doubts from my past self
ydah
force-pushed
the
fix379
branch
3 times, most recently
from
6ea1d53 to
05dcaad
Compare
Fix: #379
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.