Skip to content

Commit

Permalink
Don't require rubocop/rspec/language/node_pattern
Browse files Browse the repository at this point in the history
The node_pattern file has been removed from rubocop-rspec, and we should
no longer require it.

Also, the `RSpec/FilePath` has been split and `RSpec/SpecFilePathFormat`
can be configured to work instead.
  • Loading branch information
bquorning committed May 20, 2024
1 parent 225b71a commit 0e0550e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
7 changes: 4 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,6 @@ RSpec/ExampleLength:
- heredoc
Max: 11

RSpec/FilePath:
Enabled: false

RSpec/DescribeClass:
Exclude:
- spec/project/**/*.rb
Expand Down Expand Up @@ -184,6 +181,10 @@ RSpec/SkipBlockInsideExample:
Enabled: true
RSpec/SortMetadata:
Enabled: true
RSpec/SpecFilePathFormat:
Enabled: true
CustomTransform:
RSpecRails: rspec_rails
RSpec/SpecFilePathSuffix:
Enabled: true
RSpec/SubjectDeclaration:
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ gem 'simplecov', '>= 0.19'
gem 'yard'

# TODO: Move to gemspec when RuboCop RSpec v3 is released.
gem 'rubocop-rspec', '~> 2.27'
gem 'rubocop-rspec', github: 'rubocop/rubocop-rspec', ref: '1a8e9cb8b044983c94d'

local_gemfile = 'Gemfile.local'
eval_gemfile(local_gemfile) if File.exist?(local_gemfile)
3 changes: 0 additions & 3 deletions lib/rubocop-rspec_rails.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
require 'yaml'

require 'rubocop'

require 'rubocop/rspec/language/node_pattern'

require 'rubocop/rspec/language'

require_relative 'rubocop/rspec_rails/version'
Expand Down

0 comments on commit 0e0550e

Please sign in to comment.