New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary check in PULL_REQUEST_TEMPLATE #23

Merged

bquorning merged 1 commit into master from unused_templete_check

Apr 9, 2024

Member

ydah commented Apr 9, 2024

Before submitting the PR make sure the following are checked:

Feature branch is up-to-date with master (if not - rebase it).
Squashed related commits together.
Added tests.
Updated documentation.
Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).


          Remove unnecessary check in PULL_REQUEST_TEMPLATE

9c0137a

ydah requested a review from a team as a code owner

April 9, 2024 08:53

bquorning approved these changes

View reviewed changes

bquorning merged commit 4b1dd95 into master

27 checks passed

bquorning deleted the unused_templete_check branch

April 9, 2024 09:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet