Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InternalAffairs/ExampleDescription offenses #31

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix InternalAffairs/ExampleDescription offenses #31

merged 1 commit into from
May 20, 2024

Conversation

bquorning
Copy link
Contributor

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning
Copy link
Contributor Author

The failing parts of CI are addressed by #30.

@bquorning bquorning marked this pull request as ready for review May 20, 2024 09:56
@bquorning bquorning requested a review from a team as a code owner May 20, 2024 09:56
@ydah ydah merged commit 29eb4d3 into master May 20, 2024
25 of 27 checks passed
@ydah ydah deleted the fix-internal-affair-example-description-offenses branch May 20, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydah ydah ydah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bquorning @ydah