Add test for Package.parse

.github/workflows/test.yml

@@ -18,6 +18,18 @@ on:
   - push
   - pull_request
 jobs:
+  unit:
+    name: Unit
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ruby
+          bundler-cache: true
+      - name: Test
+        run: |
+          bundle exec test/run.rb
   docker:
     name: ${{ matrix.distribution }}
     strategy:

lib/rubygems-requirements-system/installer.rb

@@ -19,17 +19,10 @@
 
 require_relative "version"
 
+require_relative "package"
 require_relative "platform"
 
 module RubyGemsRequirementsSystem
-  Package = Struct.new(:id, :operator, :version) do
-    def valid?
-      return false if id.empty?
-      return false if operator and version.nil?
-      true
-    end
-  end
-
   Requirement = Struct.new(:packages, :system_packages) do
     def satisfied?
       packages.any? do |package|
@@ -116,7 +109,7 @@ def parse_requirements(gemspec_requirements)
 
     def parse_packages(raw_packages)
       packages = raw_packages.split(/\s*\|\s*/).collect do |raw_package|
-        Package.new(*raw_package.split(/\s*(==|!=|>=|>|<=|<)\s*/, 3))
+        Package.parse(raw_package)
       end
       # Ignore this requirement if any invalid package is included.
       # We must not report an error for this because

lib/rubygems-requirements-system/package.rb

@@ -0,0 +1,30 @@
+# Copyright (C) 2025  Ruby-GNOME Project Team
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+module RubyGemsRequirementsSystem
+  Package = Struct.new(:id, :operator, :version) do
+    class << self
+      def parse(input)
+        new(*input.split(/\s*(==|>=|>|<=|<)\s*/, 3))
+      end
+    end
+
+    def valid?
+      return false if id.empty?
+      return false if operator and version.nil?
+      true
+    end
+  end
+end

test/helper.rb

@@ -0,0 +1,16 @@
+# Copyright (C) 2025  Ruby-GNOME Project Team
+#
+# This library is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+require_relative "../lib/rubygems-requirements-system/package"

test/run.rb

@@ -0,0 +1,22 @@
+#!/usr/bin/env ruby
+#
+# Copyright (C) 2025  Ruby-GNOME Project Team
+#
+# This library is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+$VERBOSE = true
+
+require "test-unit"
+
+exit(Test::Unit::AutoRunner.run(true, __dir__))

test/test-package.rb

@@ -0,0 +1,52 @@
+# Copyright (C) 2025  Ruby-GNOME Project Team
+#
+# This library is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+require_relative "helper"
+
+class TestPackage < Test::Unit::TestCase
+  Package = RubyGemsRequirementsSystem::Package
+
+  class TestParse < self
+    def test_id
+      assert_equal(Package.new("cairo"),
+                   Package.parse("cairo"))
+    end
+
+    def test_operator_equal
+      assert_equal(Package.new("cairo", "==", "1.0"),
+                   Package.parse("cairo == 1.0"))
+    end
+
+    def test_operator_greater_than_equal
+      assert_equal(Package.new("cairo", ">=", "1.0"),
+                   Package.parse("cairo >= 1.0"))
+    end
+
+    def test_operator_greater_than
+      assert_equal(Package.new("cairo", ">", "1.0"),
+                   Package.parse("cairo > 1.0"))
+    end
+
+    def test_operator_less_than_equal
+      assert_equal(Package.new("cairo", "<=", "1.0"),
+                   Package.parse("cairo <= 1.0"))
+    end
+
+    def test_operator_less_than
+      assert_equal(Package.new("cairo", "<", "1.0"),
+                   Package.parse("cairo < 1.0"))
+    end
+  end
+end