Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests by updating aws-sdk-sqs and replacing moto #783

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

mensfeld
Copy link
Contributor

@mensfeld mensfeld commented Jan 28, 2025

continuation of #782

alongside of changes by @myumura this PR also:

  • removes all older ruby versions (older than 2.7 for now)
  • removes support for AWS SDK 2
  • pins the aws-sdk-sqs to the lowest version possible to work with localstack
  • adds full support of working specs to GH actions

… LocalStack (#782)

* Increase timeout in integration tests to fix flaky failures

* Provide an xml parser engine for aws sdk core version 2

* update aws-sdk-sqs

* Remove queue cleanup in integration tests as moto/localstack handle it automatically

* Replace moto with LocalStack in integration tests

* Replace moto with LocalStack in integration tests

* Fix LocalStack service configuration in GitHub Actions
@mensfeld mensfeld added the specs label Jan 28, 2025
@mensfeld mensfeld self-assigned this Jan 28, 2025
@myumura
Copy link
Contributor

myumura commented Jan 28, 2025

@mensfeld

Thanks for #782 review!

I've investigated the minimum aws-sdk-sqs version required to fix the integration test errors:

Tested versions:

  • 1.65.0: ❌ (Timeout and MissingParameter errors in integration tests)
  • 1.66.0: ✅
  • 1.91.0: ✅

@mensfeld
Copy link
Contributor Author

@myumura great. Let me reflect this in the gemspec then 🙏

@mensfeld mensfeld requested a review from phstc January 28, 2025 16:22
@mensfeld mensfeld marked this pull request as ready for review January 28, 2025 16:22
@mensfeld
Copy link
Contributor Author

@phstc, would you mind removing those from the CI requirement? Remaining once are 💚

obraz

@mensfeld mensfeld merged commit cfedc73 into main Jan 28, 2025
26 checks passed
@mensfeld mensfeld deleted the replace-moto-with-localstack branch January 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants