-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce JSON::Coder #718
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I love this. That's exactly what I'd need to make sure my Doing this just doesn't feel right: class Time
def to_json(*a)
iso8601(3).to_json(*a)
end
end So far I've been relying on Oj's |
4 tasks
byroot
added a commit
to byroot/json
that referenced
this pull request
Jan 13, 2025
Ref: ruby#718 The existing `Parser` interface is pretty bad, as it forces to instantiate a new instance for each document. Instead it's preferable to only take the config and do all the initialization needed, and then keep the parsing state on the stack on in ephemeral memory. This refactor makes the `JSON::Coder` pull request much easier to implement in a performant way. Co-Authored-By: Étienne Barrié <[email protected]>
byroot
added a commit
to byroot/json
that referenced
this pull request
Jan 13, 2025
Ref: ruby#718 The existing `Parser` interface is pretty bad, as it forces to instantiate a new instance for each document. Instead it's preferable to only take the config and do all the initialization needed, and then keep the parsing state on the stack on in ephemeral memory. This refactor makes the `JSON::Coder` pull request much easier to implement in a performant way. Co-Authored-By: Étienne Barrié <[email protected]>
etiennebarrie
force-pushed
the
json-coder
branch
from
January 13, 2025 14:24
889ee46
to
8bf4910
Compare
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Jan 14, 2025
…sing state Ref: ruby/json#718 The existing `Parser` interface is pretty bad, as it forces to instantiate a new instance for each document. Instead it's preferable to only take the config and do all the initialization needed, and then keep the parsing state on the stack on in ephemeral memory. This refactor makes the `JSON::Coder` pull request much easier to implement in a performant way. ruby/json@c8d5236a92 Co-Authored-By: Étienne Barrié <[email protected]>
hsbt
pushed a commit
to hsbt/ruby
that referenced
this pull request
Jan 14, 2025
…sing state Ref: ruby/json#718 The existing `Parser` interface is pretty bad, as it forces to instantiate a new instance for each document. Instead it's preferable to only take the config and do all the initialization needed, and then keep the parsing state on the stack on in ephemeral memory. This refactor makes the `JSON::Coder` pull request much easier to implement in a performant way. ruby/json@c8d5236a92 Co-Authored-By: Étienne Barrié <[email protected]>
byroot
added a commit
to ruby/ruby
that referenced
this pull request
Jan 14, 2025
…sing state Ref: ruby/json#718 The existing `Parser` interface is pretty bad, as it forces to instantiate a new instance for each document. Instead it's preferable to only take the config and do all the initialization needed, and then keep the parsing state on the stack on in ephemeral memory. This refactor makes the `JSON::Coder` pull request much easier to implement in a performant way. ruby/json@c8d5236a92 Co-Authored-By: Étienne Barrié <[email protected]>
etiennebarrie
force-pushed
the
json-coder
branch
2 times, most recently
from
January 20, 2025 11:48
05eb9af
to
10d1699
Compare
byroot
force-pushed
the
json-coder
branch
3 times, most recently
from
January 21, 2025 09:13
2ad1363
to
4dccf5b
Compare
Co-authored-by: Jean Boussier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
#to_json
methods are global, it can sometimes be problematic if you need a given type to beserialized in different ways in different locations.
Instead it is recommended to use the newer
JSON::Coder
API:The provided block is called for all objects that don't have a native JSON equivalent, and
must return a Ruby object that has a native JSON equivalent.