Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the lowest Ruby version to 3.1 #1241

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Upgrade the lowest Ruby version to 3.1 #1241

merged 10 commits into from
Feb 4, 2025

Conversation

andrykonchin
Copy link
Member

@andrykonchin andrykonchin commented Feb 4, 2025 •
edited
Loading

Changes:

  • removed old version guards for 3.1
  • removed 3.0 in CI

@eregon
Copy link
Member

eregon commented Feb 4, 2025

Looks good, please also update the README: https://github.com/ruby/spec?tab=readme-ov-file#specs-for-old-ruby-versions

andrykonchin
andrykonchin commented Feb 4, 2025
View reviewed changes
language/pattern_matching/3.1.rb Show resolved Hide resolved
library/date/strftime_spec.rb Show resolved Hide resolved
library/datetime/strftime_spec.rb Show resolved Hide resolved
library/erb/new_spec.rb Show resolved Hide resolved
library/ipaddr/new_spec.rb Show resolved Hide resolved
language/block_spec.rb Outdated Show resolved Hide resolved
@andrykonchin andrykonchin force-pushed the ak/upgrade-lowest-ruby-version-to-3-1 branch from 4cb35cd to 0bb5b56 Compare February 4, 2025 15:01
@andrykonchin andrykonchin merged commit 59e451a into master Feb 4, 2025
28 checks passed
@andrykonchin andrykonchin deleted the ak/upgrade-lowest-ruby-version-to-3-1 branch February 4, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrykonchin @eregon