update for ruby-2, rails-4 and rspec-3 #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on work done by Adam Kenger from Cantina Inc
i.e. rvm / rbenv
based on work from Dan Barron <[email protected]>
... to avoid deprecation warnings from rspec-2 to rspec-3 conversion
`be_false` is deprecated. Use `be_falsey` (for Ruby's conditional semantics) or `be false` `be_true` is deprecated. Use `be_truthy` (for Ruby's conditional semantics) or `be true` used be(true) and be(false)
|
Hi, Thanks a lot for your contribution but We can not merge it as it is as we don't want to break backward compatibility on that branch. I will review the changes which you have done and I will see if we can extract some part of the code and use it. Regarding the compatibility with new version of rails and ruby. We are working on that on separate project called |
|
@mitfik hows the upgrade of rails version going? is it done on rubycase-server-core ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates a couple specs for rspec-3
updates dependencies and a couple of queries for rails-4
NOTE: the same 2 specs that are broken on master (as of commit f3cab9e) are still broken
spec/casserver/utils_spec.rb:16 and spec/casserver/utils_spec.rb:22
NOTE: lib/casserver/authenticators/sql.rb -> matching_users() query should be updated too, but I'm lazy