Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native] Add placeholder login pages #705

Merged
merged 10 commits into from
Jan 16, 2024
Merged

[native] Add placeholder login pages #705

merged 10 commits into from
Jan 16, 2024

Conversation

hussam-i-am
Copy link
Collaborator

@hussam-i-am hussam-i-am commented Jan 10, 2024 •
edited
Loading

Adds some additional tooling for improved development and adds some placeholder pages for the login process

  • Sets up
    • Prettier
    • ESLint
    • Typescript
    • React testing library
  • Adds react-native-paper for Material Design styled components
    • Currently uses default themes, which can be overridden with chosen design colors
  • Basic login flow without any validation or authentication

Demo

Screen.Recording.2024-01-10.at.5.48.00.PM.mov

@hussam-i-am hussam-i-am self-assigned this Jan 10, 2024
@hussam-i-am hussam-i-am changed the title Add placeholder login pages [native] Add placeholder login pages Jan 11, 2024
dgreif
dgreif reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So exciting to see the app with some real content! Thanks for laying a great foundation here 🎉

@hussam-i-am hussam-i-am requested a review from dgreif January 12, 2024 19:26
haydenrou
haydenrou reviewed Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@haydenrou haydenrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!:)

@hussam-i-am hussam-i-am requested a review from haydenrou January 16, 2024 16:36
compwron
compwron approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@hussam-i-am hussam-i-am enabled auto-merge (squash) January 16, 2024 20:12
@hussam-i-am hussam-i-am merged commit 20f1ce7 into master Jan 16, 2024
@hussam-i-am hussam-i-am deleted the hussam-i-am/login-screens branch January 16, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compwron compwron compwron approved these changes

@Tonkpils Tonkpils Awaiting requested review from Tonkpils

@dgreif dgreif Awaiting requested review from dgreif

@haydenrou haydenrou Awaiting requested review from haydenrou

Assignees

@hussam-i-am hussam-i-am

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hussam-i-am @compwron @dgreif @haydenrou