Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slugs instead of ids in the wishlist urls #156

Open
leesharma opened this issue Oct 22, 2017 · 3 comments
Open

Use slugs instead of ids in the wishlist urls #156

leesharma opened this issue Oct 22, 2017 · 3 comments

Comments

@leesharma
Copy link
Collaborator

Right now, our wishlist urls look like this: /wishlists/1. URLs are part of the user interface and ids don't make for a great UI; let's make them more like this: /wishlists/dc-general!

The minimum requirements for this issue are:

  • URLs should be slug-based instead of id-based
  • The slug should be automatically generated based on the name
  • The slug should update if the wishlist name updates
  • The slug (re-)generation should be fully tested
  • Everything should be indexed appropriately
@reneesandefur
Copy link

I'd like to give this a shot!

@reneesandefur
Copy link

@leesharma Does it matter if it is custom or uses a gem?

@leesharma
Copy link
Collaborator Author

@reneesandefur Awesome! It looks like you've gotten started, but here's an answer anyway: gems are fine as long as they're good quality and there's a reason to use them. 🙂

If you add a gem, it should have decent code quality, be tested, and (preferably) be pretty common. It should also be proportional to the problem: e.g. adding a giant state machine gem to avoid a small amount of hand-written code wouldn't be worth it.

For this issue, either method (custom made or friendly_id) would work, though I'd prefer custom; friendly_id looks a bit bloated for the task at hand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants