Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] added friendly id gem, updated controller for friendly, updated model… #160

Closed
wants to merge 2 commits into from

Conversation

reneesandefur
Copy link

@reneesandefur reneesandefur commented Oct 23, 2017

… with extend friendly id and paramats for updating slug

Incorporated friendly id for slug, working locally, still working on writing tests

Resolves #156

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

Screenshots

@leesharma leesharma added the WIP label Oct 23, 2017
@seanmarcia
Copy link
Member

seanmarcia commented Nov 4, 2017

Hey @reneesandefur thanks for the PR! Looks like you haven't added tests and updated the current tests to reflect friendly_id yet (which is why CI is failing.) Do you have a plan for that?

@reneesandefur
Copy link
Author

reneesandefur commented Nov 7, 2017 via email

@micahbales micahbales temporarily deployed to project-playtime-stagin-pr-160 November 21, 2017 03:33 Inactive
@leesharma
Copy link
Collaborator

Since there hasn't been development on this branch in a few months, I'm going to close the PR. Let me know if you want me to re-open it!

@leesharma leesharma closed this Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use slugs instead of ids in the wishlist urls
4 participants