Use kramdown GFM parser #1436
Merged
Use kramdown GFM parser #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using options that are exclusive to that parser, so we should explicitly force it. Maybe middleman or kramdown could do better at validating options, but I'm leaving it as is for now.
simi
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that some markdown pages are not rendered correctly,
What was your diagnosis of the problem?
We're using options that are exclusive to that parser, so we should explicitly force it.
What is your fix for the problem, implemented in this PR?
My fix is to explicit set the parser that we want.
Before:
After:
Why did you choose this fix out of the possible options?
I chose this fix because it's the simplest approach. Maybe middleman or kramdown could do better at validating options, but I'm leaving it as is for now.