Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to native maintenance_tasks error handler. #5424

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

simi
Copy link
Member

@simi simi commented Feb 2, 2025

fixes following warning

DEPRECATION WARNING: MaintenanceTasks.error_handler is deprecated and will be removed in the 3.0 release. Instead, reports will be sent to the Rails error reporter. Do not set a handler and subscribeto the error reporter instead. (called from <main> at /home/retro/code/oss/rubygems.org/config/initializers/maintenance_tasks.rb:1)

It will be reported as following.

Rails.error.report(error, context: task_context, source: "maintenance-tasks")

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.06%. Comparing base (351587c) to head (64c456b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5424   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files         451      451           
  Lines        9391     9391           
=======================================
  Hits         9115     9115           
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi simi marked this pull request as ready for review February 2, 2025 15:22
@simi simi merged commit 553feb4 into master Feb 2, 2025
21 checks passed
@simi simi deleted the tasks-error-handler branch February 2, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants