Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch platform for musl tests with old rubygems #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Patch platform for musl tests with old rubygems #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4989cd
Update test to use node 17 PR
lloeki Jan 24, 2022
43ce7cb
Fix repo address
lloeki Jan 24, 2022
2f426ff
Patch platform for musl tests with old rubygems
lloeki Oct 18, 2021
57253f4
Fix library path for old rubygems
lloeki Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ jobs:
- name: Set metadata
id: set-metadata
run: |
docker exec -w "${PWD}" ${{ steps.container.outputs.id }} ruby -e 'puts Gem.platforms.last.to_s' | tee gem_platform
docker exec -w "${PWD}" ${{ steps.container.outputs.id }} ruby -e 'puts Gem::Platform.local.tap { |p| RUBY_PLATFORM =~ /musl/ && p.version.nil? and p.instance_eval { @version = "musl" } }.to_s' | tee gem_platform
echo "::set-output name=GEM_PLATFORM::$(cat gem_platform)"
- name: Download a single artifact
uses: actions/download-artifact@v2
Expand All @@ -395,7 +395,7 @@ jobs:
run: |
git clone https://github.com/rubyjs/mini_racer.git test/mini_racer --depth 1
cd test/mini_racer
git fetch origin refs/pull/210/head
git fetch origin refs/pull/231/head
git checkout FETCH_HEAD
git reset --hard
git clean -f -d -x
Expand Down
2 changes: 1 addition & 1 deletion ext/libv8-node/paths.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def object_paths
end

def platform
Gem::Platform.local.to_s.gsub(/-darwin-?\d+/, '-darwin')
Gem::Platform.local.tap { |p| RUBY_PLATFORM =~ /musl/ && p.version.nil? and p.instance_eval { @version = "musl" } }.to_s.gsub(/-darwin-?\d+/, '-darwin')
end

def config
Expand Down
2 changes: 1 addition & 1 deletion libv8-node.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Gem::Specification.new do |s|
s.platform = Gem::Platform::RUBY
s.authors = ['']
s.email = ['']
s.homepage = 'https://github.com/sqreen/ruby-libv8-node'
s.homepage = 'https://github.com/rubyjs/libv8-node'
s.summary = "Node.JS's V8 JavaScript engine"
s.description = "Node.JS's V8 JavaScript engine for multiplatform goodness"
s.license = 'MIT'
Expand Down