Add Arke #99
Merged
Add Arke #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfd
suggested changes
Feb 18, 2019
templates/config/arke/strategy.yaml
Outdated
| @@ -0,0 +1,15 @@ | |||
| strategy: | |||
There was a problem hiding this comment.
If you put the whole file into app.yml, you can write one-liner here, just render @config['arke'].to_yaml
There was a problem hiding this comment.
I'm not sure we need to put the whole file into app.yml
There was a problem hiding this comment.
template is wrong anyway, sources is a list, just keep it simple
There was a problem hiding this comment.
does it work? You may need to use gsub to delete --- , also better delete rendered file :)
m-an
force-pushed
the
feature/arke
branch
2 times, most recently
from
e465080 to
91cee0a
Compare
vshatravenko
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.1.5