Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vulnerability fix #39

Merged
merged 3 commits into from
Jan 16, 2025
Merged

chore: vulnerability fix #39

merged 3 commits into from
Jan 16, 2025

Conversation

RanjeetMishra
Copy link
Collaborator

@RanjeetMishra RanjeetMishra commented Jan 16, 2025

Fixes

Part of REV-1432

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.69%. Comparing base (21430bc) to head (51cc39c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   96.69%   96.69%           
=======================================
  Files           5        5           
  Lines         363      363           
=======================================
  Hits          351      351           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,12 +1,12 @@
[build-system]
requires = [
"setuptools >= 61.0",
"setuptools >= 70.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enforcing higher version for users as well. This is not needed for snyk scan.

requirements.txt Outdated
@@ -1,5 +1,5 @@
apache-airflow == 2.10.0
requests == 2.32.3
setuptools == 65.5.1 # not directly required, pinned by Snyk to avoid a vulnerability
setuptools == 70.0.0 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with pyptoject.toml, requirements.txt is not needed. Still keeping it for backward compatibility of different deployment processes.

@RanjeetMishra RanjeetMishra requested a review from am6010 January 16, 2025 06:09
@RanjeetMishra RanjeetMishra merged commit 90b4e2e into main Jan 16, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants