feat(http): update labels and regex for a couple of field (#1903)

rudderlabs · Feb 21, 2025 · 2b51393 · 2b51393
1 parent ca53abb
commit 2b51393
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 9 deletions.
diff --git a/src/configurations/destinations/http/schema.json b/src/configurations/destinations/http/schema.json
@@ -1090,11 +1090,11 @@
                 "properties": {
                   "to": {
                     "type": "string",
-                    "pattern": "^\\$(?:\\.|(\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$"
+                    "pattern": "^(?:$|\\$(?:\\.|(\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$)"
                   },
                   "from": {
                     "type": "string",
-                    "pattern": "^\\$(?:\\.|(\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$|^(?!\\$)[A-Za-z0-9!#$%&'*+.^_`|~-]{1,100}$"
+                    "pattern": "^\\$(?:\\.|(\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$|^(?!\\$)[A-Za-z0-9!#$%&'*+.^_`|~-]{0,100}$"
                   }
                 }
               }

diff --git a/src/configurations/destinations/http/ui-config.json b/src/configurations/destinations/http/ui-config.json
@@ -465,7 +465,7 @@
               {
                 "type": "mapping",
                 "label": "Enter your path parameters in sequence",
-                "note": "You could dynamically add values from fields in the RudderStack payload(using JSON path) or constants.",
+                "note": "You could dynamically add values from fields in the RudderStack payload (using JSON path) or constants.",
                 "columns": [
                   {
                     "key": "path",
@@ -483,7 +483,7 @@
               {
                 "type": "mapping",
                 "label": "Map your query parameters",
-                "note": "Map the query parameter keys to the values from fields in the RudderStack payload(using JSON path) or constants.",
+                "note": "Map the query parameter keys to the values from fields in the RudderStack payload (using JSON path) or constants.",
                 "configKey": "queryParams",
                 "default": [],
                 "separatorIcon": "colon",
@@ -515,7 +515,7 @@
               {
                 "type": "mapping",
                 "label": "Map your headers",
-                "note": "Map the header keys to the values from fields in the RudderStack payload(using JSON path) or constants.",
+                "note": "Build your Headers object by specifying the Key name, then map the values from fields in the RudderStack payload (using JSON path) or constants.",
                 "configKey": "headers",
                 "default": [],
                 "separatorIcon": "colon",
@@ -535,7 +535,7 @@
                     "label": "Value",
                     "regex": "^\\$(?:\\.|(?:\\.\\.(\\w+|\\*)|\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$|^(?!\\$)[A-Za-z0-9!#$%&'*+.^_`|~\\- /\\\\]{0,100}$",
                     "regexErrorMessage": "Please enter a valid JSON path or a constant",
-                    "placeholder": "e.g. application/json"
+                    "placeholder": "e.g. $.contentType or application/json"
                   }
                 ]
               }
@@ -570,7 +570,7 @@
               {
                 "type": "mapping",
                 "label": "Map your request payload",
-                "note": "Build your HTTP request payload using JSON path, then map the values from fields in the RudderStack payload(using JSON path) or constants.",
+                "note": "Build your HTTP request payload using JSON path, then map the values from fields in the RudderStack payload (using JSON path) or constants.",
                 "configKey": "propertiesMapping",
                 "separatorIcon": "colon",
                 "addButtonLabel": "Add request mapping",
@@ -579,15 +579,15 @@
                     "type": "textInput",
                     "configKey": "to",
                     "label": "Key",
-                    "regex": "^\\$(?:\\.|(\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$",
+                    "regex": "^(?:$|\\$(?:\\.|(\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$)",
                     "regexErrorMessage": "Please enter a valid JSON path",
                     "placeholder": "e.g: $.events.key2"
                   },
                   {
                     "type": "textInput",
                     "configKey": "from",
                     "label": "Value",
-                    "regex": "^\\$(?:\\.|(?:\\.\\.(\\w+|\\*)|\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$|^(?!\\$)[A-Za-z0-9!#$%&'*+.^_`|~-]{1,100}$",
+                    "regex": "^\\$(?:\\.|(?:\\.\\.(\\w+|\\*)|\\.(\\w+|\\*)|\\[\\d+\\]|\\[('\\w+'|\"\\w+\")\\]|\\[\\*\\]|\\.\\w+\\(\\))*)$|^(?!\\$)[A-Za-z0-9!#$%&'*+.^_`|~-]{0,100}$",
                     "regexErrorMessage": "Please enter a valid JSON path or a constant",
                     "placeholder": "e.g: $.properties.key1"
                   }

diff --git a/test/data/validation/destinations/http.json b/test/data/validation/destinations/http.json
@@ -695,5 +695,32 @@
       "ketchConsentPurposes.web must be array",
       "ketchConsentPurposes.unity.0 must be object"
     ]
+  },
+  {
+    "testTitle": "With empty propertiesMapping",
+    "config": {
+      "apiUrl": "http://sample.com/api/hooks/{{$.traits.userId}}/url/{{$.properties.event}}",
+      "auth": "basicAuth",
+      "username": "test-user",
+      "password": "",
+      "method": "POST",
+      "format": "JSON",
+      "http-connectionMode": "cloud",
+      "connectionMode": {
+        "cloud": "cloud"
+      },
+      "consentManagement": {},
+      "isBatchingEnabled": true,
+      "maxBatchSize": "10",
+      "headers": [],
+      "queryParams": [],
+      "propertiesMapping": [
+        {
+          "from": "",
+          "to": ""
+        }
+      ]
+    },
+    "result": true
   }
 ]